Repository navigation
P553 #64: class-owned paint-only measurement contract - #169
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P553 / Toad #64: Widget declares _paint_only_render; its subclass initialization resets inherited fixed-shape claims when render, _render or _render_bar changes. ScrollBar and ScrollBarCorner declare fixed-shape rendering and delete the live function-identity checks. Textual source +9/-23; combined old/current method-identity count with Toad PR989: 10 -> 0. Existing Textual measurement assertions now check inherited and replaced class renderers. Real private T232724Z Toad at P553/run3/ui/frame-{28,29}.png shows the busy band move while the unsent prompt draft remains visible; P553/resize1/ui/{before,after}.png shows its sidebar scrollbar follow a 139x39 -> 102x22 terminal resize. Paths are under /home/ts/.cache/agent-scratch/e2e-reply-latency-20261014/. Default installation unchanged; shared textual-check/.venv is absent, so no pytest pass is claimed.