Skip to content

Apply grouped style changes through one Styles.replace_rules call - #53

Merged
trissim merged 16 commits into
mainfrom
perf/native-style-cohort-lifetime-20261004
Oct 4, 2026
Merged

trissim merged 16 commits into
mainfrom
perf/native-style-cohort-lifetime-20261004

Conversation

@trissim

@trissim trissim commented Oct 4, 2026 •

Copy link
Copy Markdown

Styles.replace_rules now accepts keyword style edits as well as a rule map, normalizes both in one batch and refreshes once. The refresh now also passes the repaint request to the node. Comments are trimmed in _refresh, and dom.py is changed to call replace_rules for its keyword edits. Two test files are updated.

@trissim
trissim changed the base branch from perf/native-paint-acquisition-20261004 to main October 4, 2026 05:05
@trissim
trissim marked this pull request as ready for review October 4, 2026 05:56
Copilot AI balanced review requested due to automatic review settings October 4, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit c1c1ebe into main Oct 4, 2026
4 of 23 checks passed
@trissim trissim changed the title Publish grouped style edits through the existing rule owner Apply grouped style changes through one Styles.replace_rules call Oct 11, 2026
@trissim
trissim deleted the perf/native-style-cohort-lifetime-20261004 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants