Skip to content

Build Tree lines before cursor movement and node line lookups - #58

Merged
trissim merged 4 commits into
mainfrom
fix/tree-cursor-projection-20261004
Oct 4, 2026
Merged

trissim merged 4 commits into
mainfrom
fix/tree-cursor-projection-20261004

Conversation

@trissim

@trissim trissim commented Oct 4, 2026 •

Copy link
Copy Markdown

Tree reads its lazily built _tree_lines before it checks the cursor, reads a node's line or scrolls to a node, so those paths no longer see stale line numbers. cursor_up and cursor_down read the last line and cursor line once, select_line only moves the cursor when the line differs, and DirectoryTree reads cursor_node directly. One test file is updated.

@trissim

trissim commented Oct 4, 2026

Copy link
Copy Markdown
Author

Installed F3 reader12 remains FAILED, before recording, at the same remount data-identity assertion (25.434s). Verified Text58 assets do not establish whole restoration acceptance. Original sources/inputs unchanged; no provider/native inputs/priming; native child retired. No unchanged rerun.

Source review identifies a separate consumer counterexample: native watch_show_root selects line0/root during reactive initialization without human input. ContextTree._reveal_restored requires cursor_node None before scheduling, and _restore_cursor repeats None/exact-node admission, although the retained ContextTreeIntent.with_selected already fences actual selected model changes. Default native cursor may therefore suppress valid retained intent. Einstein owns that Toad lifecycle; native58 source/wheel remain frozen. Original logs do not record actual callback/cursor identities, so this is a source-supported path, not an observed timing claim.

Original terminal receipt SHA 25ddf2d8fecd50f70b65e2aafb1cdb27ace8fc223e1c92f1394b53fad91f71e1; trace and classification retained in the original and own artifact paths. No code/build/App/package changes for this review.

@trissim
trissim marked this pull request as ready for review October 4, 2026 09:40
Copilot AI balanced review requested due to automatic review settings October 4, 2026 09:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 456c27e into main Oct 4, 2026
4 of 23 checks passed
@trissim trissim changed the title Acquire Tree line projection before cursor restoration and navigation Build Tree lines before cursor movement and node line lookups Oct 11, 2026
@trissim
trissim deleted the fix/tree-cursor-projection-20261004 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants