Repository navigation
Remove the height-independence opt-in flags; always use declared ones - #67
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 5, 2026 07:01
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CACHE_HEIGHT_INDEPENDENT_BOXandCACHE_HEIGHT_INDEPENDENT_ARRANGEMENTclass flags are deleted fromWidget, and the six lines that set them onVerticalGroupandHorizontalGroupare removed. The arrangement cache key inwidget.pynow always checks the declared height dependency to decide whether to ignore height. Two test files are updated.