Skip to content

Skip geometry comparison in reflow when the whole screen is damaged - #81

Merged
trissim merged 7 commits into
mainfrom
perf/empty-damage-sender-admission-20261006
Oct 6, 2026
Merged

trissim merged 7 commits into
mainfrom
perf/empty-damage-sender-admission-20261006

Conversation

@trissim

@trissim trissim commented Oct 6, 2026 •

Copy link
Copy Markdown

Compositor._damage_geometry returns early when the full screen is already in the dirty regions, after calling the owner's idle check, instead of comparing every placement and discarding the result. The rest of the method always records dirty regions without checking that flag. A new test checks that damage and held placements are kept after a reflow with full-screen damage.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 5a0c733 into main Oct 6, 2026
0 of 22 checks passed
@trissim trissim changed the title Skip geometry comparisons when full-screen damage already owns repaint Skip geometry comparison in reflow when the whole screen is damaged Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants