Skip to content

Prepare visible roots once per idle step and pass them to callbacks - #82

Merged
trissim merged 2 commits into
mainfrom
perf/empty-damage-sender-admission-20261006
Oct 7, 2026
Merged

trissim merged 2 commits into
mainfrom
perf/empty-damage-sender-admission-20261006

Conversation

@trissim

@trissim trissim commented Oct 6, 2026 •

Copy link
Copy Markdown

In Screen, _refresh_pending is split so a new _refresh_requested property covers layout, scroll, repaint and recompose flags, and the idle handler resumes the update timer for those or dirty widgets without preparing roots. When only dirty regions remain, it prepares the roots once and passes them to _invoke_and_clear_callbacks, which is no longer async. One test file is updated.

@trissim
trissim marked this pull request as ready for review October 6, 2026 23:52
Copilot AI balanced review requested due to automatic review settings October 6, 2026 23:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 184a12b into main Oct 7, 2026
0 of 22 checks passed
@trissim trissim changed the title Share preparation within synchronous idle frame admission Prepare visible roots once per idle step and pass them to callbacks Oct 11, 2026
@trissim
trissim deleted the perf/empty-damage-sender-admission-20261006 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants