Skip to content

Do a visible-only scroll reflow when the only pending layout is held - #83

Merged
trissim merged 3 commits into
mainfrom
perf/held-layout-scroll-admission-20261006
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
perf/held-layout-scroll-admission-20261006

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

Screen used to switch to a full layout during a scroll whenever any layout request was pending. A new _held_layout_requests method finds requests inside subtrees that are being held, and the scroll path now stays on the visible-only reflow if all pending requests are held ones. The same method replaces the inline filter after a full layout. A test is added to the batch paint test file.

@trissim
trissim marked this pull request as ready for review October 7, 2026 00:23
Copilot AI balanced review requested due to automatic review settings October 7, 2026 00:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 3c81189 into main Oct 7, 2026
0 of 22 checks passed
@trissim trissim changed the title Keep held layout requests out of full scroll admission Do a visible-only scroll reflow when the only pending layout is held Oct 11, 2026
@trissim
trissim deleted the perf/held-layout-scroll-admission-20261006 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants