Repository navigation
Cache relative-height answers and refresh them when a widget is closing - #89
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 7, 2026 05:42
trissim
changed the title
trissim
deleted the
perf/relative-height-measurement-resource-20261007
branch
October 11, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widgetgets_height_dependency_answers, which keeps the computed box and relative-descendant answers together, andWidgetimportsRenderStyles. A new_message_pump_closinghook onMessagePumpis called when a pump starts closing, andDOMNodeuses it to tell its node list it was updated. Changes are indom.py,message_pump.pyandwidget.py, with two test files.