Skip to content

Make Widget.is_on_screen read the last published geometry only - #91

Merged
trissim merged 1 commit into
mainfrom
fix/committed-screen-membership-20261007
Oct 7, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/committed-screen-membership-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

Widget.is_on_screen used to call find_widget, which could trigger layout of offscreen parts of the screen just to answer a status question. It now checks whether the widget is in the compositor's published geometry and returns false when it has no screen. A new compositor test profiles the call to confirm it does not arrange the screen.

@trissim
trissim marked this pull request as ready for review October 7, 2026 07:45
Copilot AI balanced review requested due to automatic review settings October 7, 2026 07:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit a2111b4 into main Oct 7, 2026
2 of 22 checks passed
@trissim trissim changed the title Read committed screen membership without acquiring geometry Make Widget.is_on_screen read the last published geometry only Oct 11, 2026
@trissim
trissim deleted the fix/committed-screen-membership-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants