Skip to content

Keep layout requests from different widgets separate while held - #96

Merged
trissim merged 3 commits into
mainfrom
perf/scroll-parent-coordinate-acquisition-20261007
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
perf/scroll-parent-coordinate-acquisition-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

messages.Layout.can_replace now only replaces a pending layout message from the same widget, so one widget's request no longer swallows another's. Screen gets _has_actionable_layout_requests, used by the scroll path, and after a held subtree is released its pending request now sets _layout_required and schedules an idle check. widget.py is also changed for nested scroll coordinates, and three test files are updated.

@trissim
trissim marked this pull request as ready for review October 7, 2026 17:37
Copilot AI balanced review requested due to automatic review settings October 7, 2026 17:37
@trissim
trissim merged commit cf73255 into main Oct 7, 2026
2 of 22 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim trissim changed the title Preserve layout source custody and acquire nested scroll coordinates once Keep layout requests from different widgets separate while held Oct 11, 2026
@trissim
trissim deleted the perf/scroll-parent-coordinate-acquisition-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants