Skip to content

Reuse a complete cached subtree for viewport-only and kept-path requests - #99

Merged
trissim merged 2 commits into
mainfrom
perf/native-scroll-placement-20261007
Oct 7, 2026
Merged

trissim merged 2 commits into
mainfrom
perf/native-scroll-placement-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

SubtreeGeometry.matches takes a require_complete flag, and a cached placed subtree that was captured in full now matches a viewport-only request with the same key. In the compositor, the special case that re-arranged a widget on a kept path is replaced by a check that only re-arranges when the cached copy is partial or changed. One new test file covers it.

@trissim
trissim marked this pull request as ready for review October 7, 2026 19:42
Copilot AI balanced review requested due to automatic review settings October 7, 2026 19:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 7665765 into main Oct 7, 2026
2 of 22 checks passed
@trissim trissim changed the title Reuse complete placed geometry for viewport and retained requests Reuse a complete cached subtree for viewport-only and kept-path requests Oct 11, 2026
@trissim
trissim deleted the perf/native-scroll-placement-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants