Skip to content

P448: qualify goals through the existing managed native workflow - #1135

Draft
trissim wants to merge 6 commits into
mainfrom
fix/p448-native-goal-qualification
Draft

trissim wants to merge 6 commits into
mainfrom
fix/p448-native-goal-qualification

Conversation

@trissim

@trissim trissim commented Oct 21, 2026 •

Copy link
Copy Markdown

P448 native goal qualification — unfinished

Original production controls in #1133 are merged. This PR deletes the duplicate in-process ACP fixture and reuses NativeSession. It removes test-created Conversation.agent shadow state across the related fixture/journey/adapter family, using bind_agent and agent_binding instead. P401's slow-open reads stay with pi-story-tool (#1115).

Current repair

  • SessionObservation initializes its captured binding as NoAgentBound and retains source/revision checks.
  • Core ACP fixture declarations opt into the existing --comms-root capability. Native setup installs LaunchRoot rather than writing the retired ambient override; cleanup derives executable threads from ThreadRole.executor.
  • Compaction uses existing event/turn owners and a single shared private wire root.
  • Goal qualification uses a truly empty result for missing-output failure and an actual managed peer for standby. The latest mention check targets the owning GoalText, not a global screen occurrence.

Evidence

NRA AST inventory: 283 production + 289 test modules, zero omissions for the binding family. Delete the shadow writer and migrate readers; no production alias, alternate codec or new lifecycle store.

With installed Core 7dc1894e2, the nine-case run completed 6 passed / 3 failed. Real native goal creation and stale-edit refusal, three observation cases and compaction passed. Failure/Retry repaint, mention lookup and DM feedback failed. After correcting empty-output/live-peer setup, the focused goal pair still completed 2 failed: failure disconnected the UI while the header remained Active; mention lookup chose a non-link occurrence. The scoped GoalText fix is published at 0849f82 but unverified.

Core #2566 now repairs a demonstrated execution codec defect: untagged same-shape Running and Unknown variants decoded as Runnable. Its new wire family is not installed. Latest Core source batch: 16 passed / 1 CLI exit timeout, not green. Installed 7dc group-stop proof independently passed; it does not qualify this UI.

mi-1a retains the frozen Retry-click failure and runner #2575; I own the product investigation. Absence of ACP goal log entries does not prove absence of a control request: source uses RuntimeProxy directly to the owner's socket. That correction was sent; the delivery outcome was Failed and has not been replayed.

Still open

  • Actual Retry click advances the same goal exactly one generation and completes on a fresh isolated run.
  • Ledger-only repaint in the open goal details; scoped mention navigation and preserved draft/reader position.
  • Fresh DM progress, exactly one reply, hidden-tab return and reopen. Held-reply feedback currently remains Sent.
  • Fresh paired installed acceptance. Both attempted upgrades after 7dc rolled back; neither is acceptance.

The reusable native-helper head f7f7448 was handed to pi-story-tool; Core67d compatibility is not qualified here. #1115's full P401 workflow is not replaced by #1132.

No original session or uncertain input replayed. No full suite, local ratchet, prefix bypass or installed-package mutation.

Assumed: no new-head installation or UI success follows from these source checks.

@trissim

trissim commented Oct 22, 2026

Copy link
Copy Markdown
Author

Native feedback qualification checkpoint

The installed-afb three-case batch executed and failed all three cases (214.30s):

  • Ledger repaint and mention cases failed before their bodies, awaiting ACP session attachment. Their retained ACP logs end at session/load.
  • The direct-message case reached the held provider, but waited for the obsolete literal Responding. The provider subsequently failed because the test never released it. This is not evidence of a missing UI activity update.

The shared direct/channel journeys now consume the existing owners instead of restating labels:

  • NotificationStatus.working proves activity.
  • HistoryViews.message_notifications_for_references reads original message references; the removed message-object reader is no longer called.
  • The direct journey requires the actual reply reference and model-context read proof; the ignored channel journey requires IgnoredProgress, read proof and no answer.
  • MessageNotification.summary supplies the expected visible summary on return/reopen. No copied Responding, Responded, Checked, or no response policy remains in these journeys.

Focused Ruff, Python 3.14 compilation and git diff --check pass. No new native input was sent after this change; application acceptance remains open. The approved P464 runner must be merged and installed before using its new home policy.

Source inventory reused NRA ModuleSyntaxIndex: 277 Toad production modules parsed with six Python-3.14 syntax omissions, 289 test modules with zero omissions, and 452 installed Core modules with four omissions under the existing NRA Python-3.12 environment. The log names all ten omitted files; all declarations changed/consumed by this checkpoint were parsed. Dynamic rebinding is unresolved. The first inventory attempt with Core's Python 3.14 did not execute because that environment lacks tree_sitter. No complete-Core AST claim is made.

Evidence: /home/ts/.cache/agent-scratch/unit-goalblock/afb-shared-first-native.log, native-feedback-check.log, native-feedback-owner-ast-existing-env.log, native-feedback-publish.log.

Separately, mi-1a's verify51b failed native preflight before UI (await_get_state, 10120ms/10000ms, zero provider posts/input proofs). That frozen attempt is not replayed; native lifecycle owner assignment was requested from claude-code in message 18015. No cap was increased.

Assumed: Core's declared progress capabilities and linked answer references, rather than historical English labels, are the qualification contract. This checkpoint fixes the test premise, not the unverified product workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant