Skip to content

Drop the candidate catch-up drain Core's bus batch deletes #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trissim wants to merge 1 commit into from
Closed

Drop the candidate catch-up drain Core's bus batch deletes #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/textual/test_conversation_kind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import pytest

from agent_comms.candidate_maintenance import drain_candidate_catchup
from agent_comms.channel_targets import ChannelTarget, ThreadTarget
from agent_comms.comms import Comms, wire
from agent_comms.field_codec import FieldCodec
Expand All @@ -27,7 +26,6 @@ def copied_conversations(tmp_path):
viewer = original.messaging.user_identity(str(tmp_path)).name
original.messaging.send("peer", "#team", "channel body")
original.messaging.send("peer", viewer, "direct body")
drain_candidate_catchup(original.root)
StoreBackup.copy_tree(original.root, tmp_path / "copied")
return Comms(tmp_path / "copied"), viewer

Expand Down
2 changes: 0 additions & 2 deletions tests/textual/test_wire_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Textual-facing: the presentation window; a wire source pages one conversation and notices when Core replaces its reading."""

from agent_comms.candidate_maintenance import drain_candidate_catchup
from agent_comms.channel_targets import ChannelTarget
from agent_comms.comms import wire
from agent_comms.historical_views import ConversationObservation
Expand Down Expand Up @@ -75,7 +74,6 @@ def bodies(prepared):
later = AfterSequence(LiveCursor(grown.through.cursor.sequence + 1))
bounded = source.read(PageRequest(NEWER_END, grown.through), later)
assert bodies(bounded) == ["arrived later"] and bounded.page.after == later and not bounded.page.has_newer
drain_candidate_catchup(comms.root)
current = source.observe(grown.revision)
assert isinstance(source.observe(current.revision), Unchanged)

Expand Down
Loading