Repository navigation
Use domain image records and shared ACP action encoding - #1165
Merged
Merged
Conversation
trissim
changed the title
trissim
marked this pull request as ready for review
October 23, 2026 21:21
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Core's domain ImageInput module in ACP prompts, clipboard images and prompt resources. Saved transcript tool kinds now carry capability classes, so both ACP ToolCall readers use the same AcpToolAction translator as Core publication. No second literal table or compatibility import is added.
Depends on OpenHCSDev/agent-comms#2913 at ff66279da. Core must land first; then rerun this PR's ratchet. Run 40025551025 on 5727ccc reports TypeErrors +1 in acp/prompt.py, clipboard_image.py and prompt/resource.py because its declared Core main does not yet contain image_input.py. The workflow selects Core from pyproject.toml at .github/workflows/ci.yml:42-51. This dependency is explicit; the failed hosted run is not reported as a pass.
Source inventory: refactor-audit Package.load parsed all 288 Toad modules with zero omissions and found all three old image imports. All are migrated. Both ToolTranscript.kind readers in acp/status.py are migrated.
Interpreter proof against the paired Core checkout: all changed modules import, prompt.ImageInput is Core's new declaration, both byte limits equal 4194304, and ToolCallStatus.from_transcript converts a saved ReadAction to SDK kind read. No test runs. No route-lock edits.
Assumed: Core #2913 lands first and paired installation updates both repositories together.