Skip to content

Move stale tests to current API owners #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 23, 2026
Merged

Move stale tests to current API owners #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d30fd1e
Move stale tests to the current API owners
trissim Oct 23, 2026
07358af
Merge branch 'main' into fix/tests-follow-api-owners
trissim Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions tests/model/test_coordination_snapshot.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion tests/model/test_queue_attachment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_capture_after_binding_names_the_bound_scope(tmp_path):
attachment = QueueAttachment()
token = attachment.begin("source")
attachment.bind(QueueChangedUpdate(scope, 0, AvailableQueueProjection()), "source", token)
assert attachment.capture_human_input(comms, scope) == HumanInputOrigin.capture(comms, scope.claim_scope)
assert attachment.capture_human_input(comms, scope) == HumanInputOrigin.capture(comms, scope.claimed_identity)


def test_capture_after_a_replacement_begins_is_refused(tmp_path):
Expand Down
6 changes: 3 additions & 3 deletions tests/textual/test_conversation_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async def test_channel_dm_and_feed_keep_typed_destinations_through_open_send_and
):
mode = await target.open(context)
screen = app.selected_session
assert screen.navigation_target_name == target.name
assert screen.navigation_target == target
await screen.wait_content_ready()
chat = screen.query_one(CommsChatView)
await ui.until(
Expand Down Expand Up @@ -138,8 +138,8 @@ async def test_renamed_dm_reopens_the_same_tab_and_sends_to_the_current_name(wor
history = chat.message_history
await ui.until(
lambda: history.source_ready
and history.revision.selection.peer.name == "renamed"
and history.revision.selection.peer == peer.incarnation
and history.page_source.revision.selection.peer.name == "renamed"
and history.page_source.revision.selection.peer == peer.incarnation
and "BEFORE_RENAME" in ui.painted(window),
why="the renamed conversation's captured source and painted message",
)
Expand Down
6 changes: 3 additions & 3 deletions tests/textual/test_saved_history_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async def saved_history(workspace, ui):
page = workspace.comms.transcripts.thread_transcript_page("saved")
conversation = ui.conversation
ui.attach_agent(ui.detached_agent())
await conversation.transcript.snapshot(page)
conversation.transcript.received(page)
await ui.until(lambda: conversation.contents.query_children(TranscriptHistory), why="the saved history")
return page, conversation.contents.query_children(TranscriptHistory).first(), conversation.query_one(SessionDetails)

Expand All @@ -40,7 +40,7 @@ async def test_saved_history_is_unavailable_while_its_source_is_parked_and_retur
await ui.until(lambda: "Saved history not loaded" in details.title, why="saved history reported not loaded")
assert not history.state.reports_coverage

await conversation.transcript.snapshot(page)
conversation.transcript.received(page)
await ui.until(lambda: history.state.reports_coverage, why="coverage reported again")
await ui.until(lambda: "Saved history available" in details.title, why="saved history reported available again")
assert "Saved history available" in details.overview_text
Expand All @@ -61,6 +61,6 @@ async def test_a_live_message_does_not_count_as_saved_history_coverage(workspace
await conversation.transcript.reveal_retained(history)
await ui.until(lambda: "Saved history not loaded" in details.title, why="saved history reported not loaded")
assert not conversation.transcript.reports_coverage
await conversation.transcript.snapshot(page)
conversation.transcript.received(page)
await ui.until(lambda: "Saved history available" in details.title, why="saved history reported available")
assert tuple(history.pages) == pages
2 changes: 1 addition & 1 deletion tests/textual/test_sent_message_drawn_once.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async def test_a_start_notice_after_the_saved_history_draws_the_message_once(wor
agent = ui.detached_agent("source")
ui.attach_agent(agent)
# The page read finds the message in the session file before Core's start notice arrives.
await view.transcript.snapshot(workspace.comms.transcripts.thread_transcript_page("source"))
view.transcript.received(workspace.comms.transcripts.thread_transcript_page("source"))
await ui.until(lambda: ui.painted(view.window).count(TOKEN) == 1, why="the saved message")

await agents.deliver(agent, {
Expand Down
Loading