Skip to content

Fix stale welcome row and undeclared resume fixture #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 2 commits into from
Oct 23, 2026
Merged

Fix stale welcome row and undeclared resume fixture #1172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8919b26
Update welcome tests for declared threads and current rows
trissim Oct 23, 2026
a0071ce
Merge branch 'main' into fix/welcome-view-declared-thread
trissim Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/textual/test_welcome_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ async def test_opening_a_thread_run_elsewhere_opens_its_history_read_as_the_user
)
async with workspace.app(session=False) as ui:
await ui.until_shows(THREADS)
await focus_row(ui, "ThreadRow")
await focus_row(ui, "ThreadStatusRow")
await ui.press("enter")
await ui.until(lambda: len(ui.tabs()) == 1, why="the thread's tab")
assert ui.sender_of(ui.selected_tab) == workspace.viewer
Expand Down Expand Up @@ -96,6 +96,7 @@ async def test_going_back_from_the_only_tab_stays_on_it(workspace):


async def test_a_launch_that_names_a_session_opens_it(workspace):
workspace.thread("saved-session", "team")
async with workspace.app(session=False, resume="saved-session") as ui:
await ui.until(lambda: len(ui.tabs()) == 1, why="the named session's tab")
assert ui.selected_tab == ui.tabs()[0].identity
Expand Down
Loading