Repository navigation
Open conversation details using their observed row name - #1174
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 22:09
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a conversation details title read a fresh global registry snapshot to resolve the name of the peer already shown by the row. If that incarnation had just disappeared, the second lookup raised KeyError.
The title handler now opens target=self.label (src/toad/widgets/session_details.py:175). label already reads self.row.name at :167. The global references read is deleted.
Keep peer and its constructor parameter: ChannelActivity.rows keys retained widgets by row.peer at src/toad/widgets/channel_activity.py:36, and changed_keys reads row.peer at :74. Both constructor sites remain valid: src/toad/conversation_kind.py:290 and src/toad/widgets/channel_activity.py:61. A grep across src and tests finds those two calls and the declaration.
Evidence only, no navigation edits: ThreadNavigator.open reads comms.registry.snapshot().require(target) at src/toad/thread_navigation.py:68-71. RegistryNames.require canonicalizes the name, indexes threads, and converts the missing key into UnregisteredThreadError("Thread {canonical!r} is not registered.") at agent-comms src/agent_comms/registry_provenance.py:155-160. The preparation worker returns task.result() at toad src/toad/work_preparation.py:293, so it propagates the exception. open's only catch is the earlier source-origin RelationViolationError at thread_navigation.py:56-59; the missing-name lookup is outside it and escapes to the caller. No catch added.
Validation at 921b1ce: the changed file parses; git diff --check is clean; pushed head equals ls-remote. No tests run. SessionNavigation and WorkspaceSessions are untouched.
Assumed: ChannelActivity still needs peer as its stable row key; missing-name navigation behavior is intentionally unchanged pending the next order.