Repository navigation
Bind saved-history fixtures to the retained owner before loading - #1175
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 22:11
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The saved-history fixture registered
savedbut kept the selected tab unbound, attached a processless agent, and handed that unrelated tab a source page. The UI correctly refused to claim retained coverage.The fixture now opens a MailboxTab for the registered owner's exact incarnation and root through
session_navigation.new, withMainScreen.from_threadas the screen constructor. That constructor callsbind_thread(screens/main.py:301-310), which installs ThreadIdentity(owner, root) before the history widget mounts. The normal bound source loads and publishes its own saved history; the fixture waits for that coverage before reading the page used for later park/revalidation checks.received(page)injection.reveal_retainedcalls to the existing BoundView method with (owner, history).str(details.title)reads Textual Content's actual text instead of applying string membership to Content's character sequence.Based on main f9aa367, which merged #1169. Only tests/textual/test_saved_history_coverage.py changes. No private attribute mutation or patch of application code.
git diff --checkpasses; no tests run.Assumed: execution is checked by the review fork; the fixture's eight-row saved journal remains the retained source used by those checks.