[trissim]

The sender helper conflated a tab's target with its sending identity. Delete the abstract Ui.sender_of and its TextualUi implementation. Both sender assertions now inspect messages submitted through the running composer and published on the Core bus.

Current head: 69d67a5. Tests are not run here; the review fork runs them.

• Welcome test: app.selected_session.thread_identity.thread_name() must be scribe, which states the tab target. Type hello scribe, press Enter, wait for that body/target in history_page(CommandTarget.named("scribe"), viewer=NamedViewer(workspace.viewer)), then assert the actual message sender is workspace.viewer.
• Shared channel test: type hello shared channel, press Enter, wait for that body in history_page(CommandTarget.named("#all")), then assert the actual message sender is owner-b. The wait does NOT filter on sender, so the known defect fails at the sender assertion. tests/open_defects.toml is unchanged; shared-channel-tab still lists this test.
• Current Core has no channel_history method (source grep); history_views.py:198 declares history_page for channel targets as well as threads. The archived-thread test already uses that owner. This avoids introducing another AttributeError from a stale example API.
• Keep ui.new_session() in the last-tab close test. All of its assertions remain. Only tests changed.

Grep: grep -rn sender_of tests src returns no matches. No alias, replacement sender helper, skip, xfail, or production change.

Assumed: the submitted body uniquely identifies each message in its fresh workspace; history_page's bounded newest page contains that fresh message. The owner-b expectation is intentionally retained as the listed product defect, not changed to today's user sender.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.