Repository navigation
Build the session details test notifications from Core's declared state - #1178
Merged
Merged
Conversation
The fixture passed "owner", "Responded", "" positionally into MessageNotification, so a str sat in the DeliveryProgress state field and ThreadStatusModel.known raised on .notification_label. Core declared these fields typed on 10-16 (83ee78593); only this test kept the old shape. No toad src constructs MessageNotification; Core builds it at assignment_states.py:161 with a typed state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toad main is red:
tests/textual/test_session_details.py::test_details_are_one_row_until_opened_and_then_bounded[rgb/ansi]fails withAttributeError: 'str' object has no attribute 'notification_label'.The cause is in the test, not the app.
MessageNotification("owner", "Responded", "", ...)positionally, which puts the str""intostate: DeliveryProgress.ThreadStatusModel.known(Coreui_model/status.py:68) then reads.label, which callsstate.notification_labeland raises.App path: nothing in toad src constructs
MessageNotification. Core builds it atassignment_states.py:161with a declared state, and toad's ownThreadStatusModel.knowncaller (conversation_turn.py:227) passes a typed presentation. The real session details panel doesn't take this path.Fix: the fixture builds
MessageNotification(FrozenRecipient("owner", "owner"), "peer", AcknowledgedProgress(), message=...). Every assertion is unchanged.Test:
test_session_details.py2 passed; it is 2 failed on main e14a5df.Not fixed here, also red on main:
test_message_notification_title.py:22builds the same stale shape, includingdetailandbusyfields that no longer exist. Rewriting it needs a decision about which declared state stands for "Responding" and "busy", so it's reported to the commander separately.🤖 Generated with Claude Code