Repository navigation
Drive the notification title test through Core's declared progress states - #1179
Merged
Merged
Conversation
…ates The test still called the removed show_result/show_error API and built MessageNotification from the stale positional shape with `detail` and `busy` fields that no longer exist, so it failed on main. It now hosts the widget inside a real conversation (the project-path owner its details need), feeds it CheckedNotifications and UnavailableNotifications through show(), and takes the states from Core's family: ReadingProgress is what a busy selected response shows (notification_progress.py ShownToModelProgress.selected_notification), CompletedProgress what a completed assignment shows. Titles are compared with MessageNotification.summary instead of restated strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/textual/test_message_notification_title.pywas red on main: it called the removedshow_result/show_errorand builtMessageNotificationfrom the stale positional shape ("Responding",detail,busy).ProjectPathOwnerthatToolContent's mount needs (linked_rows.pyReferenceRendering._on_mount).CheckedNotifications/UnavailableNotificationsthroughMessageNotifications.show.ReadingProgressis what a busy selected response shows (agent_comms/notification_progress.pyShownToModelProgress.selected_notification,busy=True),CompletedProgresswhatCompletedAssignmentshows (assignment_states.py:456).MessageNotification.summary, not restated strings.Test: main 1 failed (
AttributeError: show_result); branch 1 passed.🤖 Generated with Claude Code