Skip to content

Use native tool declarations for saved command previews - #594

Merged
trissim merged 1 commit into
mainfrom
fix/saved-tool-previews
Oct 13, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/saved-tool-previews

Conversation

@trissim

@trissim trissim commented Oct 13, 2026

Copy link
Copy Markdown

Saved ToolCallStatus reconstruction discarded the command preview by setting its title to tool_name, even while retaining raw_input. The live path already derives the title and kind through NativeTool.start and declaration-owned detail. Reconstruct the recorded call first, then derive both through that same owner once. Delete the competing title builder. No transcript scroll-path or Textual edits.

Source-first census using existing ModuleSyntaxIndex covered 584 Toad/Core modules with zero parse omissions; relevant consumers include the fragment producer and live ToolCall widget. Dynamic family registration/MRO read semantically. Six additions, five deletions in one production file. Real installed-prefix UI verification pending; no automated tests under current project instructions. #593 remains separate.

@trissim

trissim commented Oct 13, 2026

Copy link
Copy Markdown
Author

Working checkpoint: 4 additions / 3 deletions in src/toad/acp/status.py. Candidate wheel built and installed in private prefix toad-tool-previews-17ccddf2-core-d1997b1f; reused the unchanged installed 81-package graph, dependency check passes. The real toad-comms launcher on isolated display165 opened retained saved history without new model input. This is NOT visible preview acceptance: backend showed NativePiUnavailable during initialization, and the retained tool rows have not yet been inspected visibly. The failed first launch used the prefix instead of its bin directory; launch-error.log preserves that deterministic setup failure. Default links/user processes unchanged. Source census 584 modules, no omissions. No automated tests or protected scroll/Textual edits. Selection-paint change remains separate and awaits required plan approval. Owned verification UI/display/fork stopped; this owner retains completion.

@trissim
trissim marked this pull request as ready for review October 13, 2026 06:58
Copilot AI balanced review requested due to automatic review settings October 13, 2026 06:58
@trissim
trissim merged commit f9107b8 into main Oct 13, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants