Repository navigation
Delete session status CSS-class decisions; paint existing typed roles - #679
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 16, 2026 03:07
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the round trip
SessionDetails computed status, wrote CSS class names, and made selectors reinterpret the same state. Three local class writers and their three selector branches are gone; notification auto height uses Static’s existing behavior.
Codex10762 correctly rejected my four forwarding SessionStatus classes: they only wrapped LineRole. They are now deleted in ddafcf8. title_role returns the existing NoticeRole/WorkingRole/MutedRole directly, with attention precedence unchanged. Content.is_same compares native text/spans before assigning; no last-title/status cache. Mounted native style-update hook retains theme repaint. Separate observed/local activity and the sole throbber sweep are unchanged.
No authored dependency-pin, Forms, geometry, clock or global palette changes.
Evidence
Previous source preview on owned :210 exercised genuine idle/working/attention paint, palette change and tab return. The forwarding-class deletion preserves those exact existing role values and native value comparison; no repeat full UI journey per Codex10762. Source parses, wrapper declarations/consumers are absent and diff whitespace checks pass. No tests/fakes/provider input/build/install by this owner. Codex retains the installed check with me.
Remaining
This small PR works against the existing Core flag API. Paired #681/#943 carries Core’s proper status family across all models/consumers, eliminating that upstream flattening; it contains this deletion too. Five geometry selectors await core-route-counts’ native foundation. Neither source review nor this PR claims scrolling/performance or full DM history acceptance.