Repository navigation
P55: narrow dialog catches and decide catalog fields from their typed state - #730
Merged
Merged
Conversation
… typed state The dialog chooses the catalog editor from Core's CatalogTargetField and asks each CatalogField whether its value is the one its catalogs were prepared for (CatalogField.prepared); the five 'parameter.catalog is not None' probes are gone, and catalog refresh configures each editor from the newly prepared fields by name. Each catch now names the failure it expects: NativePiUnavailable from catalog discovery, RouteChanged from TargetContext.current() (which now raises Core's RouteChanged), ValueError from decoding the form's input in edited(), and OSError from spawning the login program. Provider login calls run_login() as Core main declares it; CommandDialog no longer holds a Comms. The missing-choice line is returned instead of raised and caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #729. It fixes the debt ratchet against the installed Toad 6be909d (ForeignAbsenceProbe +5 in comms_command_dialog.py) and codex's broad-catch review. I merged #729 without running the ratchet; this corrects it.
CatalogTargetField. EachCatalogFieldsays whether its value is the one its catalogs were prepared for (CatalogField.prepared). The fiveparameter.catalog is not Noneprobes are gone, and catalog refresh configures each editor from the newly prepared fields by name.NativePiUnavailablefor catalog discovery. Core'sRouteChangedforTargetContext.current(), which now raises it instead of a plain ValueError (still a ValueError subclass, so other callers are unchanged). ValueError only aroundedited(), which decodes the form's input (for example "Unknown ThinkingLevel name: ''"). OSError around spawning the login program. Programming errors now raise.run_login(comms=...), P128: every toad test file collects against current owners #1007's signature. On Core main that raised TypeError, so "Connect a provider" from the dialog was broken. It now callsrun_login(), and CommandDialog no longer holds a Comms.Ratchet
--root src/toad/ --base 6be909dab --head 624f9dd15: exit 0, no positive deltas (/home/ts/.cache/agent-scratch/rts-results/p55-toad-ratchet-claude-session.json). Real UI on isolated Xvfb :254 with plain st: the dialog opened, the model changed to gpt-5.4-mini through the shared picker, the catalog refresh re-enabled Apply, and there were no crash files (/home/ts/wt/toad-forms-migration/.scratch/p68-live/p55b/model-changed.png). Goes with Core #1071.🤖 Generated with Claude Code