Repository navigation
P45: generate Settings and sort forms from ObjectState declarations - #732
Merged
Merged
Conversation
(cherry picked from commit c5aed5f)
(cherry picked from commit 698006a)
(cherry picked from commit 907840a)
(cherry picked from commit bff49a4)
(cherry picked from commit ea33717136d3b0e1ebd3fd3d73b8b49c7b2ce441, without its dependency pins) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 2a67605, without its scratch file) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve ToadApp bases by keeping main's VisibleReadMarking with the branch's ScreenWidth modes. Pin objectstate 5.0.0 (ad8727278), formbridge 0.2.0 (ebe2fa917) and textual 25aad306e from git; the lock also moves python-introspect to 0.3.0 and zmqruntime to 0.6.5. FormPart reads textual's DEFAULT_LAYER instead of repeating the layer name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
# Conflicts: # pyproject.toml
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P45: Settings and the session sort form are now generated from the saved-settings ObjectState declarations through FormBridge's ParameterInfo kinds, and drawn with Textual's native geometry and paint instead of TCSS. This replaces #670. #670's P29 part landed as #727, and its P55/reconnect parts landed as #729/#713.
Owners after this change
FieldPathbinds to ObjectState'sDottedFieldPath(bind()->DeclaredField). Parent addresses come fromDottedFieldPath.parent, so there's no second path string.DirectDataclassInfo,OptionalInfo, ...) chosen by its metaclass.FieldView.ofreads the declaredshows; there's no type switch in Toad.FormPart(BoxGeometry, PaintLayer, FramePaint)declares geometry and paint directly, withDEFAULT_LAYOUTper view.src/toad/screens/settings.tcssis deleted.SavedSettingsover ObjectState; Settings edits the same state anddiscard()reverts it.Pins (exact git revs; none of these are on PyPI)
Checks
--root src --base origin/main --head 844b53a6c): exit 0, with no positive deltas.st, isolated AGENT_COMMS_ROOT and XDG directories), running this branch with the merged stack:/home/ts/.cache/agent-scratch/claude-forms/final-{2-settings,4-reopened,5-search,6-gamma}.pngandp45-*.png.🤖 Generated with Claude Code