fix(drivers): 修复 github_releases gh_proxy 条件写反导致代理永不生效 - #99
Open
Mcchen1008 wants to merge 1 commit into
Open
Mcchen1008 wants to merge 1 commit into
Mcchen1008 wants to merge 1 commit into
Conversation
proxy() 原逻辑为 if (!p || url.startsWith("http")) return url,
而所有传入的 GitHub 下载 URL 均以 http 开头,导致 p + url 分支
永远不可达——配置了 gh_proxy 的用户直链仍直连 GitHub。
改为 if (p && url.startsWith("http")) return p + url,对齐上游
OpenList Go 版 drivers/github_releases 的 GhProxy 语义(代理非空
且 URL 为 http(s) 时加前缀)。附 3 个单元测试覆盖配置/未配置/
非 http 链接三种情况。
Co-Authored-By: GLM <glm@z.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
src/backend/drivers/github_releases/util.ts的proxy()判断条件写反:所有传入该函数的 URL(
asset.browser_download_url、release.zipball_url/tarball_url、f.download_url)均以http开头,因此p + url分支永远不可达——配置了gh_proxy后,release 资产 / 源码包 / README 的下载直链仍直连 GitHub,代理配置完全无效。本 PR 将条件改为
if (p && url.startsWith("http")) return p + url,对齐上游 OpenList Go 版drivers/github_releases的 GhProxy 语义(代理非空且 URL 以 http 开头时加前缀),并新增 3 个单元测试覆盖「已配置 / 未配置 / 非 http 链接」三种情况。用户可感知的行为变化:配置
gh_proxy后,GitHub Releases 驱动的下载直链会正确加上代理前缀(修复前该配置无效)。无配置 / 存储 / API 兼容性变化。
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
不适用(未检索到已有对应 Issue)。
Testing / 测试
npx tsx --test src/backend/drivers/github_releases/util.test.ts→ 3 pass / 0 fail(新增测试)npx tsx --test "src/backend/drivers/**/*.test.ts"→ 134 pass / 0 fail(无回归)npx tsc -p tsconfig.json --noEmit→ 0 errorsgo test ./...(本仓库为 TypeScript / Serverless 移植版,不适用)测试平台:Linux x64 / Node v24.21.0 / pnpm 9.15.4
Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
prettier格式化(新增测试文件已用 prettier 格式化;util.ts的既有格式状态未做全文件重排,保持最小 diff)。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Tests / 测试
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。