feat: improve jobs list display#9441
Open
pjwerneck wants to merge 4 commits into
Open
Conversation
pjwerneck
changed the title
pjwerneck
force-pushed
the
pjwerneck/improve-job-list-display
branch
from
e90c3c5 to
fef46fb
Compare
pjwerneck
force-pushed
the
pjwerneck/improve-job-list-display
branch
from
75d5c7b to
9a1cc86
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
packages/syft-job/src/syft_job/job_repr.py:796
- The DO-role hint uses
job_client.jobs[...]while the other tips in this summary useclient.jobs[...]. This inconsistency makes the copy/paste guidance error-prone; please use a single variable name.
lines.append("")
lines.append(
"💡 Use job_client.jobs[0].approve() to approve jobs or job_client.jobs[0].accept_by_depositing_result('file_or_folder') to complete jobs"
)
- Don't use ty:ignore flags - Keep root_email arg for backwards compatibility - Properly escape HTML fields - Make JobsList.has_do_role public, since enclave.jobs now uses it instead of JobsList. _root_email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve job list display with a clean summary when accessed in a notebook cell.
Changes
__str__()_/_repr_html_methods toJobsListthat return a clean summary.__repr__'s current behavior is preserved.Testing
tests/unit/test_datasets_jobs_repr.pyAsana task
https://app.asana.com/1/1185126988600652/project/1210542925864934/task/1214425085848186?focus=true