Conversation
…tead of per node Batch service tracker changes so telemetryd builds all connector configs in a change and publishes once per location. Interpolated parameters are computed once and the duplicate connector guard works.
…S-20352 # Conflicts: # opennms-dao/src/main/java/org/opennms/netmgt/dao/support/DefaultServiceTracker.java # opennms-dao/src/test/java/org/opennms/netmgt/dao/support/DefaultServiceTrackerTest.java
cgorantla
requested review from
christianpape,
indigo423 and
marshallmassengill
September 25, 2026 17:34
marshallmassengill
approved these changes
Sep 25, 2026
marshallmassengill
left a comment
marshallmassengill
left a comment
Contributor
There was a problem hiding this comment.
Approving but there are some minor things we may want to fix since we're in here:
- Failed config build drops the node permanently. ConnectorManager.java:116. Verified: node 0 never republished after later changes. Retry failed refs on the next update call; don't rethrow.
- Failed publish retries only on a change in that location. ConnectorManager.java:136. Verified: no-change refreshes and other-location changes don't retry. Acceptable; a retry timer would close it.
- HashMap order churns twin patches. LocationPublisher.java:43. Verified: adding 3 configs across a resize = 567 ops at 190 nodes, 2289 at 1530; LinkedHashMap = 3.
- Per-service publish/remove are dead in production. OpenConfigTwinPublisher.java:33. Verified: only the openconfig itest calls them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish telemetryd connector configs once per location instead of per node.
Batch service tracker changes so telemetryd builds all connector configs in a change and publishes once per location. Interpolated parameters are computed once
Fixes startup time with Telemetryd
External References