Fixing 955 - #956
Fixing 955#956AgreeDK merged 2 commits into
Conversation
|
Thanks, @nagisml A few non-blocking thoughts, fine as a follow-up: While the worker recalculates, the progress bar sits at 100% with no feedback. A self.progress.emit(0, 0) just before recalculate_distances() would switch it to busy mode (the dialog already handles total == 0). Approving — thanks again! |
…enSAK-Org#956) After rebasing onto beta, GsakImportWorker still referenced the removed original_path, and recalculate_distances()/distances_up_to_date() assumed the global engine had been switched to db_path. With session_for() it no longer is, so a non-active target's distances would have been computed from and written to the active database. - database: _session_on(db_path) picks get_session() for the active DB and session_for() otherwise; the distance helpers use it. - gsak_import_dialog: update distances of target_db_path or the active DB. - Narrow Optional paths for session_for() and fix the Engine annotation in importer (mypy clean). - test: patch session_for instead of init_db. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Followup of #947 fixing #955