feat: Migrate to SvelteKit 3 - #18
Draft
hhvrc wants to merge 4 commits into
Draft
Conversation
Run `sv migrate sveltekit-3`, then reconcile the output with the repo's conventions: - Remove svelte.config.js; SvelteKit 3 no longer reads it. `preprocess` moves to the sveltekit() options in vite.config.ts alongside the adapter and compilerOptions that already lived there. - Drop the deprecated `config.alias` entry. `@openshock/svelte-core/*` specifiers resolve through the package's own `exports` field instead, so dev, build, check and the shadcn-svelte CLI all keep working without the deprecation warning. - Point tsconfig at `$app/tsconfig` instead of ./.svelte-kit/tsconfig.json, dropping the compiler options it now supplies. Use `include: ["src", "*"]` rather than `["src"]` so vite.config.ts stays type-checked, as it was under the generated config. - Keep the demo route on the `@openshock/svelte-core/*` self-name imports used everywhere else rather than the `#lib` subpath imports the migration introduced, so the repo has a single alias mechanism. Verified with check (302 files, 0 errors), build, test (227 passing) and lint.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drop the changeset file; master removed changesets.
Brings #20, #21 and #22 onto the migration branch. package.json keeps this branch's `next` pins for `@sveltejs/kit` and `@sveltejs/adapter-auto` while taking master's removal of `@sveltejs/package`, which #20 dropped and nothing here uses. pnpm-lock.yaml is regenerated from this branch's copy rather than master's, so the SvelteKit 3 prereleases stay pinned and master's dependency changes resolve on top. eslint.config.js needed a fix git could not see: it imported `./svelte.config.js` for the parser's `svelteConfig` option, and the migration deleted that file in favour of vite.config.ts. The option is an optimisation rather than a requirement, so it is dropped here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.