Skip to content

Fix: barrel imports - #295

Open
santipalenque wants to merge 2 commits into
mainfrom
fix/barrel-imports
Open

Fix: barrel imports#295
santipalenque wants to merge 2 commits into
mainfrom
fix/barrel-imports

Conversation

@santipalenque

@santipalenque santipalenque commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

https://app.clickup.com/t/9014802374/86baz0zt6

Summary by CodeRabbit

  • New Features
    • Added guidance for importing components through individual module paths.
  • Bug Fixes
    • Updated component exports to prevent the upload input from being included in the shared component entry point.
  • Documentation
    • Documented import paths for components with heavier third-party dependencies.
  • Chores
    • Updated the package version to 5.0.44-beta.0.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a3d52af5-f2a3-4f1f-8ed7-2a78eb24aa0f

📝 Walkthrough

Walkthrough

The package version is updated to 5.0.44-beta.0. UploadInputV3 is removed from the components barrel export, and the README documents direct imports for components excluded from that barrel.

Changes

Component release update

Layer / File(s) Summary
Beta package version
package.json
The package version changes from 5.0.43 to 5.0.44-beta.0.
Direct component import contract
src/components/index.js, readme.md
UploadInputV3 is removed from the barrel export, and the README documents importing excluded components through individual module paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main change: fixing barrel imports by removing a component from the barrel export.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/barrel-imports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smarcet
smarcet requested review from smarcet and a lite review from Copilot and removed request for smarcet August 11, 2026 17:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the library’s component “barrel” export strategy to reduce unintended dependency requirements from importing lib/components, and documents the preferred per-module import approach for consumers.

Changes:

  • Removed UploadInputV3 from the src/components/index.js barrel export and listed it under the “3rd party deps” commented-out section.
  • Added README guidance recommending direct per-component import paths and explaining why some components are excluded from the barrel.
  • Bumped the package version to 5.0.44-beta.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/components/index.js Removes UploadInputV3 from the barrel and documents it as excluded due to external deps.
readme.md Adds guidance on importing from individual component paths and rationale for excluding some exports from the barrel.
package.json Updates package version to 5.0.44-beta.0.
Suppressed comments (1)

readme.md:31

  • This new "Importing Components" section makes the following "Enviroment Variables" heading look like a sub-section of it. If this is meant to be a top-level section, bump it back to ## and fix the spelling to "Environment".
will not resolve them.

### Enviroment Variables

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/index.js
Comment thread readme.md
Comment thread src/components/index.js
export {default as GroupedDropdown} from './inputs/grouped-dropdown'
export {default as UploadInput} from './inputs/upload-input'
export {default as UploadInputV2} from './inputs/upload-input-v2'
export {default as UploadInputV3} from './inputs/upload-input-v3'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santipalenque Removing this export still breaks one consumer in summit-admin master.

fntechgit/summit-admin#1013 migrated the barrel imports of UploadInputV3 to the path import, but src/components/forms/event-category-form.js:33 was added by #1024 (merged 55 minutes after #1013) and still does:

import { UploadInputV3 } from "openstack-uicore-foundation/lib/components";

Because lib/ is a compiled UMD bundle, a missing named export is not a build error — it resolves to undefined and the event category edit page will fail at render ("Element type is invalid") as soon as summit-admin bumps to a uicore version that includes this change.

Suggested fix: land a one-line follow-up in summit-admin switching that import to

import UploadInputV3 from "openstack-uicore-foundation/lib/components/inputs/upload-input-v3";

(same pattern as #1013) and merge it before, or together with, the uicore bump that picks this PR up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commited change, now admin is safe for this version change: fntechgit/summit-admin@4bc167d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants