Skip to content

feat(clubs): closed type - #1879

Open
veselcraft wants to merge 22 commits into
masterfrom
closed-groups
Open

feat(clubs): closed type#1879
veselcraft wants to merge 22 commits into
masterfrom
closed-groups

Conversation

@veselcraft

@veselcraft veselcraft commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member 
██████████  ██████  ██      ██    ██████    ██████████  
██████████  ██████  ██      ██    ██████    ██████████  
██            ██    ████  ████  ██      ██        ██    
██            ██    ████  ████  ██      ██        ██    
████████      ██    ██  ██  ██  ██      ██      ██      
████████      ██    ██  ██  ██  ██      ██      ██      
██            ██    ██      ██  ██      ██    ██        
██            ██    ██      ██  ██      ██    ██        
██          ██████  ██      ██    ██████    ██████████  
██          ██████  ██      ██    ██████    ██████████
  • закрыть стену для невступивших
  • скрыть в глобальной ленте закрытые группы, если не вступал
  • оставить заделку для частных групп и инвайтов (конкретно - учесть, что клозед это и 1 и 2)
  • сделать гуи для принятия юзера в секту
  • закрыть для антиучастника всё (включая аудиозаписи, они по умолчанию должны не показываться в поиске)
  • в редактировании группы можно поставить закрытую (для частной сделать задел, когда появятся инвайты в группу)

@veselcraft

veselcraft commented Nov 4, 2026

Copy link
Copy Markdown
Member Author
tiktok_comedy_fun610_7650781371438304532.mp4

@veselcraft
veselcraft force-pushed the closed-groups branch 2 times, most recently from fc997a6 to 127545a Compare November 4, 2026 16:49
@myslivets

myslivets commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

██████████ ██████ ██ ██ ██████ ██████████
██████████ ██████ ██ ██ ██████ ██████████
██ ██ ████ ████ ██ ██ ██
██ ██ ████ ████ ██ ██ ██
████████ ██ ██ ██ ██ ██ ██ ██
████████ ██ ██ ██ ██ ██ ██ ██
██ ██ ██ ██ ██ ██ ██
██ ██ ██ ██ ██ ██ ██
██ ██████ ██ ██ ██████ ██████████
██ ██████ ██ ██ ██████ ██████████

gang?

@veselcraft
veselcraft marked this pull request as ready for review November 9, 2026 23:51
@veselcraft
feat(clubs): closed type WIP, halffully implement group requests
4a60c5a
@veselcraft
fix: 500 error if user not authed
5711625
@veselcraft
feat(groups): let user change g type
bcf5185
@veselcraft
chore(wall): hide posts from closed groups in global feed
46c7505
@veselcraft
fix: 500 on wall post
40dab82
@veselcraft
chore(lint)
8abb1a0
@veselcraft
chore: rename merge sql
dd05287
@veselcraft
chore: upd node packages
4f66095
@veselcraft
feat(groups): add type level in lists
64a9ab5
@veselcraft
feat(groups): add canBeViewedBy everywhere
aa5cd68
@veselcraft
chore: upd composer
c15e018
@veselcraft
fix(groups): stupid typo
dd83cf8
@veselcraft
feat(groups): implement accept/reject in groups
5838821
@veselcraft
feat(clubs): closed type WIP, halffully implement group requests
9972d38
@veselcraft
chore(lint, tests, checks)
34b96a6
@veselcraft
chore(l18n): add new strings
8578264
@veselcraft
chore(git): merge conflicts came wrong
15ea1cc
@veselcraft
chore: lint and some stupid git merge errors
45bc17c
@veselcraft
fix: section's placeholders won't show up
1c2da60
@veselcraft
fix: stupid errors
706110d
@veselcraft
fix: wrong class styles for sub buttons
8bc233b
@veselcraft
chore: upd screenshot
61f0505
@veselcraft

veselcraft commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

требуется ревью
если всё устраивает, СДЕЛАЙТЕ SQUASH пжлст.

crythoughts
crythoughts reviewed Nov 10, 2026
View reviewed changes
Comment thread Web/Presenters/templates/Group/View.latte
</div>
</div>
{if $club->canBeViewedBy($this->user)}
<div class="fictional_profile_section" n:if="$albumsCount > 0 || ($thisUser && $club->canBeModifiedBy($thisUser))">

@crythoughts crythoughts Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше n:if

@veselcraft veselcraft Nov 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

так тут и так n:if

Comment thread Web/Presenters/templates/Group/Requests.latte
<a class="profile_link" href="/club{$club->getId()}/setFlag?user={$user->getId()}&accept=1&hash={rawurlencode($csrfToken)}">
{_friends_accept}
</a>
<a class="profile_link" href="/club{$club->getId()}/setFlag?user={$user->getId()}&accept=0&hash={rawurlencode($csrfToken)}">

@crythoughts crythoughts Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше через window.OVKAPI.call и сделать для этого методы

@veselcraft veselcraft Nov 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в подписчиках для админки ситуация такая же, ничего не знаю

Comment thread VKAPI/Handlers/Board.php
@@ -26,6 +26,10 @@ public function addTopic(int $group_id, string $title, ?string $text = null, boo
$this->fail(15, "Access denied");
}

@crythoughts crythoughts Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

крч в вкапи методы getFollowers с заявками и поля в клубе

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crythoughts crythoughts crythoughts left review comments
@WerySkok WerySkok Awaiting requested review from WerySkok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veselcraft @myslivets @crythoughts