Skip to content

Fix PHPunit matrix for nette/forms <3.3 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WerySkok merged 2 commits into from
Oct 28, 2026
Merged

Fix PHPunit matrix for nette/forms <3.3 #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a161e68
test: drop stale Runtime::item expectations for nette/forms <3.3
WerySkok Oct 28, 2026
af61a99
test: gate item expectations on the PHPStan version
WerySkok Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions tests/Rule/LatteTemplatesRule/PresenterWithoutModule/LatteTemplatesRuleForPresenterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,17 +1205,19 @@ public function testForms(): void
'default.latte',
];
} else {
$expectedErrors[] = [
'Parameter #1 $item of static method Nette\\Bridges\\FormsLatte\\Runtime::item() expects int|object|string, mixed given.',
142,
'default.latte',
];
$expectedErrors[] = [
'Unable to resolve the template type T in call to static method Nette\\Bridges\\FormsLatte\\Runtime::item()',
142,
'default.latte',
'See: https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-template-type',
];
if (DependencyVersion::phpstanAtLeast23()) {
$expectedErrors[] = [
'Parameter #1 $item of static method Nette\\Bridges\\FormsLatte\\Runtime::item() expects int|object|string, mixed given.',
142,
'default.latte',
];
$expectedErrors[] = [
'Unable to resolve the template type T in call to static method Nette\\Bridges\\FormsLatte\\Runtime::item()',
142,
'default.latte',
'See: https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-template-type',
];
}
$expectedErrors[] = [
'PHPDoc tag @var with type Nette\\Forms\\Controls\\BaseControl is not subtype of type Nette\\Forms\\Controls\\TextArea.',
55,
Expand Down Expand Up @@ -1358,19 +1360,6 @@ public function testForms(): void
55,
'default.latte',
];
if (!DependencyVersion::netteFormsAtLeast33()) {
$expectedErrors[] = [
'Parameter #1 $item of static method Nette\\Bridges\\FormsLatte\\Runtime::item() expects int|object|string, mixed given.',
142,
'default.latte',
];
$expectedErrors[] = [
'Unable to resolve the template type T in call to static method Nette\\Bridges\\FormsLatte\\Runtime::item()',
142,
'default.latte',
'See: https://phpstan.org/blog/solving-phpstan-error-unable-to-resolve-template-type',
];
}
}
if (DependencyVersion::phpstanAtLeast23()) {
// PHPStan 2.3 dead-code checks on nette/forms 3.1 generated template code
Expand Down
Loading