Skip to content

Fix submodule modification CI build skip bug - #772

Draft
Spartan322 wants to merge 1 commit into
masterfrom
fix/submodule-change-build
Draft

Fix submodule modification CI build skip bug#772
Spartan322 wants to merge 1 commit into
masterfrom
fix/submodule-change-build

Conversation

@Spartan322

@Spartan322 Spartan322 commented Aug 21, 2026

Copy link
Copy Markdown
Member

In a case where only the submodules in openvic-simulation is changed, changed-files may skip CI build checks, this fixes that bug.

@Spartan322
Spartan322 requested a review from a team as a code owner August 21, 2026 22:06
@Spartan322 Spartan322 added bug Issue that describes something dysfunctional or erroneous topic:buildsystem Issue that applies to the buildsystem of the module, like modifying or improving the buildsystem dependencies Issue relating to dependencies, whether updating, adding or removing them deps:submodules Issue relates to a submodule dependency deps:github actions Issue relates to a github action dependency labels Aug 21, 2026
@Spartan322
Spartan322 marked this pull request as draft August 22, 2026 01:16
@Spartan322

Spartan322 commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Turns out this does not fix the issue where submodules inside a submodule are accounted for, need to go back to the drawing board.

@Spartan322

Copy link
Copy Markdown
Member Author

See tj-actions/changed-files#2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue that describes something dysfunctional or erroneous dependencies Issue relating to dependencies, whether updating, adding or removing them deps:github actions Issue relates to a github action dependency deps:submodules Issue relates to a submodule dependency topic:buildsystem Issue that applies to the buildsystem of the module, like modifying or improving the buildsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants