Remove the conditional z/OS indentation in pcre2grep - #981
Merged
Merged
Conversation
NWilson
force-pushed
the
user/niwilson/pcre2grep-zos-indent
branch
from
September 12, 2026 18:03
dfd5383 to
28778f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The z/OS block in pcre2grep alters the indentation level with an ifdef, which I find ugly.
The fallthrough behaviour looks slightly incorrect too. There is a small behavioural adjustment with this.
I have also changed Windows to an "else if" in the same chain of ifs. I believe this has no effect in practice, since directories and wildcards are mutually exclusive conditions.