Bound idle user cleanup across retired SID churn - #199
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated user-manager turnover could leave inactive cleanup requests for retired SIDs queued while new owners arrived. Queue admission now prunes obsolete inactive requests before admitting new entries, preserving active request identity and revision. The bound is 132 entries: 128 tracked owners plus at most four active completions.
The deterministic 512-SID churn regression reproduces growth past that bound on the previous source. It exercises logon and notification decisions with held SID gates and separately accepted cleanup completions. Existing cases retain coalescing, failed cleanup, blocked liveness, independent progress and shutdown ownership.
The concurrent-capture fixture now uses short-line record pressure to prove draining and reported loss during a storage stall. CI exposed its previous dependence on decoding 8 MiB inside a two-second window; separate aggregate/native cases retain byte-volume coverage. Twenty repetitions and the serialized journal suite passed with unchanged timeouts.
Validation: twenty focused race repetitions, full uncached race suite, vet and Windows/Linux staticcheck passed. Three integrated user/linger repetitions passed after merging the policy refactor; documentation links and whitespace passed. Final source
b8fe16d43ce45331194c3e588beec827d2d04c1cpassed CI 34765087985. Eight delayed-adapter/ownership cases passed ten repetitions each under SYSTEM and a headless standard user (1.816/0.753 seconds), without skips and with complete process/profile cleanup.