Observe adapter errors before lifecycle serialization - #203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow adapter error formatting or classification could hold lifecycle serialization, blocking snapshots and independent operations. Launch, cleanup, native-query, user-manager and operation completion now observe error text and classification before taking the decision lock. Identity and cancellation are rechecked when accepting the observation. Operation publication joins any concurrently accepted manager cancellation under the same lock, while preserving the observed protocol error.
Both new public lifecycle regressions fail on previous main: a partially created process with a blocked error formatter stalls independent start/stop and snapshots, and a blocked start-error classifier stalls cancellation. Twenty repetitions pass with the fix. Cleanup ownership, retained diagnostics and cancellation-before-publication are checked after releasing each delayed observation.
Validation: full uncached race suite passed (manager 59.834s, journal 46.218s), vet and Windows/Linux staticcheck passed. Three repetitions of the final ten-case cleanup/cancellation matrix passed. Documentation links and complete diff/privacy review passed. Exact source
dd515c8bf09dbb8ca7a0682132920c520fa0a583passed CI 34766883282 and all ten cases ten times per SYSTEM/headless standard-user identity (2.569s/1.121s), with no skips and full fixture cleanup. The binary/source hashes and retained raw evidence were verified. Full R2 writer and worker-class acceptance remains open.