Potential fix for code scanning alert no. 3: Incomplete multi-character sanitization - #3
Merged
Merged
Conversation
…er sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
PRATHAM777P
marked this pull request as ready for review
April 27, 2026 18:15
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+42
to
+44
| text = text | ||
| .replace(/<script[\s\S]*?<\/script>/gi, "") | ||
| .replace(/<style[\s\S]*?<\/style>/gi, "") |
Comment on lines
+42
to
+43
| text = text | ||
| .replace(/<script[\s\S]*?<\/script>/gi, "") |
| do { | ||
| previous = text; | ||
| text = text | ||
| .replace(/<script[\s\S]*?<\/script>/gi, "") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/PRATHAM777P/AlphaMind/security/code-scanning/3
Use iterative replacement for the multi-character block-tag removals (
script,style,noscript) so replacements are applied until the string stabilizes.Best minimal fix (without changing intended functionality):
src/tools/fetch/web-fetch-utils.ts, around lines 38–41 inhtmlToMarkdown, replace the chained single-pass.replace(...)calls with a smalldo...whileloop that repeatedly removes those blocks until no further changes occur.stripTags, whitespace normalization) unchanged.No new imports or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.