Repository navigation
fix(nist-ir-ai): repair invalid JSON escapes before parsing the assessment - #1197
Merged
Merged
Conversation
…sment Model replies quoting Windows paths and URLs verbatim carry backslashes that are invalid JSON escapes; json.loads(strict=False) does not forgive them, so URL-heavy issues landed as raw strings instead of parsed assessments. Add a repair pass that doubles only the offending backslashes - it runs strictly after a failed parse, so well-formed replies are never rewritten - then re-parse, then salvage. War-room note says when repair fired; dataset rows and the contract are unchanged.
scottbrumley
added a commit
that referenced
this pull request
Oct 15, 2026
… release] (#1198) The playbooks and prompts under ai/nist-ir live outside the packs and carry no pack version, so their changes had no changelog home. One dated file per change set, in the DC-facing format: what you get, what changed, what to update. Seeded with today's Issue Assessment entry (#1196, #1197).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (PoV tenant): URL-heavy issues produced assessments written as raw strings - backslashes in quoted paths/URLs are invalid JSON escapes, the parse failed, and salvage could not recover because the bad escape precedes every cut point.
Fix: a repair pass in SOCFWPromoteAssessment that doubles only invalid-escape backslashes, run strictly after a failed strict parse (valid replies are never rewritten), then re-parse, then salvage. War-room note states when repair fired. No dataset/contract change.
Testing:
Not merging until the Playground evidence lands.