fix: Let configured file storage reach SQLite on WASI - #6
Merged
Conversation
scottmarchant
approved these changes
Sep 4, 2026
scottmarchant
left a comment
Collaborator
There was a problem hiding this comment.
Great idea, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SQLiteConnectionSourcecurrently replaces every configured WASI storage value with.memory, so.file(path:)never reaches SQLite.sqlite-nionow supports file-backed databases through the stock WASI filesystem, so this removes the obsolete workaround and passes the configured file path through.Existing
.memorybehavior on WASI stays unchanged. Non-WASI code is unchanged.Links
What changed
SQLiteConnectionSource.swift- preserve.memorystorage on WASI and pass.file(path:)directly toSQLiteConnection.Storage.file.Tested
~/.swiftly/bin/swiftly run swift test +6.3.3~/.swiftly/bin/swiftly run swift build +6.3.3 --swift-sdk swift-6.3.3-RELEASE_wasm