Skip to content

Fix: NPE in peer evaluation getSheet when evaluatee is null #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PathNotFound404 merged 1 commit into from
Apr 30, 2026
Merged

Fix: NPE in peer evaluation getSheet when evaluatee is null #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backend/src/main/java/com/tcu/projectpulse/config/DataInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,8 @@ public void run(ApplicationArguments args) {
Student grace = studentRepository.save(student("Grace", "Green", "g.green@tcu.edu", section2324));
Student henry = studentRepository.save(student("Henry", "Harris", "h.harris@tcu.edu", section2324));

// Seed WARs and PeerEvaluations using recent weeks so reports show data immediately
// Seed WARs using recent weeks so reports show data immediately
addWars(alice, 3, thisMonday.minusWeeks(3));
addPeerEvaluations(alice, bob, 2, thisMonday.minusWeeks(2));
studentRepository.save(alice);

// --- Teams (2024-2025) ---
Expand Down
2 changes: 1 addition & 1 deletion backend/src/main/java/com/tcu/projectpulse/peerevaluation/service/PeerEvaluationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public PeerEvaluationSheetResponse getSheet(Long studentId, LocalDate anyDateInW
List<EvaluationEntryResponse> entries = teammates.stream()
.map(tm -> {
PeerEvaluation pe = existing.stream()
.filter(e -> e.getEvaluatee().getId().equals(tm.getId()))
.filter(e -> e.getEvaluatee() != null && e.getEvaluatee().getId().equals(tm.getId()))
.findFirst()
.orElse(null);
return toEntryResponse(tm, pe);
Expand Down
Loading