Repository navigation
Carry gaps never searched into the evolutionary audit and run comparison - #19
Merged
Merged
Conversation
…and run comparison Gain and loss calls in evolutionary_events.tsv were built on absences whether or not Recore had searched them, so a gain on a cluster below --min-prevalence read as an audited result. New columns count those absences and say why, a call none of whose absences were searched drops one support level, and every affected call is tagged and explained. compare_runs.py also counted NOT_SEARCHED_* cells as calls, listing every unsearched cell as a new correction against older runs; they are absences now, and a change in search coverage has its own class.
Rv3810, below the prevalence floor, now carries the not-searched tag and wording in its mechanism card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, which told gaps never searched apart from searched empty ones in the states file and the report. Two places downstream still treated them as audited absences.
Evolutionary audit. Gains and losses are made of absences, and
evolutionary_events.tsvbuilt them whether or not Recore had searched those gaps; under the default--min-prevalence, every gain on a cluster in fewer than one genome in ten read as an audited call.absent_not_searchedandnot_searched_reason(low_prevalence,no_cluster_sequence,no_fasta).mechanism_detailgetsabsences_not_searched. When only some were, it getsabsences_not_searched=N/Mand no downgrade. Either wayrecommended_wordingsays so.Run comparison.
benchmarks/compare_runs.pycounted any state other thanABSENTas a call, so comparing against a run from before #18 listed everyNOT_SEARCHED_*cell as a new correction. They are absences now, and a cell searched in one run and not the other issearch_coverage_changed, counted apart fromchanged_cells.Checked by running it
-D warnings, 187 library tests, 3 integration tests with minimap2 required,mkdocs build --strict.compare_runs.py, tutorial output against a copy withABSENTin place ofNOT_SEARCHED_*: 11 new corrections before the fix, 0 after, with 11search_coverage_changed; a run against itself is allsame.