Skip to content

Auth: document the magic-link feature - #49

Open
RandyJDean wants to merge 1 commit into
07-09-auth_frontend_login_verify_session_and_logoutfrom
07-09-auth_document_the_magic-link_feature
Open

Auth: document the magic-link feature#49
RandyJDean wants to merge 1 commit into
07-09-auth_frontend_login_verify_session_and_logoutfrom
07-09-auth_document_the_magic-link_feature

Conversation

@RandyJDean

@RandyJDean RandyJDean commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
  • docs/auth-feature.md mirrors the email-feature doc: shape, login
    walkthrough, dev log-link trick, and configuration table
  • AGENTS.md auth row now reflects magic links + Spring Session JDBC

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

RandyJDean commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@graphite-app

graphite-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (07/10/26)

2 reviewers were added to this PR based on Henry Chen's automation.

Comment thread docs/auth-feature.md Outdated
email, receives a single-use link, and clicking it establishes a server-side session delivered as an
httpOnly cookie.

**Unified signup/login.** Requesting a link never reveals whether an account exists (the response is

@spiffyy99 spiffyy99 Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the design of this signup flow is pretty focused on avoiding revealing whether or not the email is in the system, which it seems is why we have a silent rate limit?

That's fine to target but seems to lead to bad UX for legitimate users here because users also won't know if they are rate limited. This may actually lead to more attempts.

What if we rate limited (with a 429) for all emails, including non-registered ones? There will still be no distinction between registered and non-registered emails. Does that make sense?

@RandyJDean
RandyJDean force-pushed the 07-09-auth_frontend_login_verify_session_and_logout branch from 94387bf to 90a5199 Compare July 31, 2026 17:24
@RandyJDean
RandyJDean force-pushed the 07-09-auth_document_the_magic-link_feature branch from cbf9d36 to 5681d50 Compare July 31, 2026 17:24
- docs/auth-feature.md mirrors the email-feature doc: shape, login
  walkthrough, dev log-link trick, and configuration table
- AGENTS.md auth row now reflects magic links + Spring Session JDBC

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@RandyJDean
RandyJDean force-pushed the 07-09-auth_document_the_magic-link_feature branch from 5681d50 to 3f5cf30 Compare July 31, 2026 18:17
@RandyJDean
RandyJDean force-pushed the 07-09-auth_frontend_login_verify_session_and_logout branch from 90a5199 to 253efb0 Compare July 31, 2026 18:17
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants