Repository navigation
Fix editor reload loop on products with combinations - #378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357.
Reproduction
On the published 3.2.4 ZIP (same source as base
fdcf3c1), open PrettyBlocks with a local demo product's combination URL asstartup_url, including a query and the#/1-taille-s/8-couleur-blancfragment. On PrestaShop 9.1.4, the iframe requests?qa=variant?prettyblocks=1rather than a separate edit flag. The back office then repeatedly reloads with more copies of?prettyblocks=1instartup_url.Fix
prettyblocks=1in the query and retaining the original combination fragment and other query values.Thanks to @inodia-agency for the detailed reproduction.
Validation
7a9650cba56aff68992d88c4f9fa9e2d6da7237520062eca00a718f475b9ab09.No version bump, tag, release, or database change.