Repository navigation
Disable sorting on PrettyBlocks action columns - #380
Open
PercolatingStudio wants to merge 1 commit into
Open
PercolatingStudio wants to merge 1 commit into
PercolatingStudio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331.
Reproduction on the published 3.2.5 ZIP
On PrestaShop 8.2.7, open Design → Pages and click the sort control on “Open in PrettyBlocks”. The grid returns HTTP 500 with
Unknown column 'edit2'. Returning to the listing URL without the sort parameters still returns 500 because PrestaShop saved the invalid order for the current employee and shop.Change
Make the shared PrettyBlocks action column non-sortable by default (CMS, products and categories). It is a link, not a database field. Document how to recover a listing that already has the bad order: open the CMS list as the affected employee in the affected shop with
cms_page[orderBy]=position&cms_page[sortOrder]=asc. This uses PrestaShop's native sorting; no database edit or automatic preference migration is needed.Thanks to @grismajeur-admin for the report and @hwctblanc for the sorting suggestion.
Validation
180bae34fca1c4eb4d170131eb2788efae5f39e1546dbd0e5609304c04911020). GitHub CI rebuilds it independently.edit2sort recovers via the documented URL and stays recovered on the normal listing.git diff --checkpass.No version bump, migration, or release.