You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review the code for bugs and security vulnerabilities #15
hey , I am a security researcher and developer would like to audit your contract . I you can assign me the issue here , i have total of 1 year of experience doing auditing and have 25 findings in my portfolio with 3 critical, 6 High, 4 Medium , 10 Low.
I have taken a overview of your contract , i found few gas optimization and certain function which can follow best security practices . Should i make a request ?
Hi @mudgen is it intended that ERC20Facet.sol does not implement external mint function?
where can I read more about what function that should/should not be added in ERCs Facet?
I want to learn more about this.
thanks
edit: maybe because usually mint is a privileged function and Compose try to not using modifier?
@farismln A mint external function would require authentication which we don't have in ERC20Facet.sol.
Remember we are making composable, reusable, onchain facets.
So someone making a diamond would add all the external functions from the deployed ERC20Facet to their diamond. And to have external mint functionality such a user would make their own custom facet with an external mint function (which used LibERC20.sol), and they would deploy their custom facet and add its functions to their diamond.
I certainly need to write more user documentation to show how Compose is intended to be used by users.
Activity
shubu258 commentedon Oct 20, 2025
hey , I am a security researcher and developer would like to audit your contract . I you can assign me the issue here , i have total of 1 year of experience doing auditing and have 25 findings in my portfolio with 3 critical, 6 High, 4 Medium , 10 Low.
shubu258 commentedon Oct 20, 2025
I have taken a overview of your contract , i found few gas optimization and certain function which can follow best security practices . Should i make a request ?
mudgen commentedon Oct 20, 2025
Yes, make an issue or pull request or both.
shubu258 commentedon Oct 20, 2025
okay cool
farismln commentedon Oct 21, 2025
Hi @mudgen is it intended that
ERC20Facet.soldoes not implement externalmintfunction?where can I read more about what function that should/should not be added in ERCs Facet?
I want to learn more about this.
thanks
edit: maybe because usually mint is a privileged function and Compose try to not using modifier?
mudgen commentedon Oct 21, 2025
@farismln A mint external function would require authentication which we don't have in
ERC20Facet.sol.Remember we are making composable, reusable, onchain facets.
So someone making a diamond would add all the external functions from the deployed ERC20Facet to their diamond. And to have external mint functionality such a user would make their own custom facet with an external mint function (which used
LibERC20.sol), and they would deploy their custom facet and add its functions to their diamond.I certainly need to write more user documentation to show how Compose is intended to be used by users.
adamgall commentedon Oct 26, 2025
@mudgen is there expected to be an explicit deliverable for this issue?
mudgen commentedon Oct 26, 2025
@adamgall No, so I am converting this to a discussion.