Repository navigation
feat(cli): add shared diamond introspection adapter - #410
Merged
0x76agabond merged 2 commits intoOct 7, 2026
Merged
Conversation
👷 Deploy request for compose-diamonds pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 60ba0c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0x76agabond
force-pushed
the
codex/diamond-adapter
branch
from
October 6, 2026 18:56
47bdd21 to
60ba0c8
Compare
Contributor
CLI CoverageCommit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a typed Diamond introspection adapter shared by ERC-8153 and ERC-2535.
Changes Made
IDiamondAdapterand shared ABI on top of the existing RPC adapter.compose inspectand bytecode validation through the new adapter.Checklist
Before submitting this PR, please ensure:
forge fmt- Not applicable; no Solidity files changed.forge testnot run; no Solidity files changed.Make sure to follow the contributing guidelines.
Additional Notes
33 targeted tests passed, including 7 Foundry-backed validation tests. Changed files passed ESLint and the CLI bundle build passed. Standalone
tscstill reports an existing unrelated error invirtualStorageLayout.ts:325.