Skip to content

feat(cli): add shared diamond introspection adapter - #410

Merged
0x76agabond merged 2 commits into
Perfect-Abstractions:mainfrom
0x76agabond:codex/diamond-adapter
Oct 7, 2026
Merged

0x76agabond merged 2 commits into
Perfect-Abstractions:mainfrom
0x76agabond:codex/diamond-adapter

Conversation

@0x76agabond

@0x76agabond 0x76agabond commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add a typed Diamond introspection adapter shared by ERC-8153 and ERC-2535.

Changes Made

  • Define the four-method IDiamondAdapter and shared ABI on top of the existing RPC adapter.
  • Route compose inspect and bytecode validation through the new adapter.
  • Add adapter and regression tests, plus a separate CLI patch changeset.

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No Solidity files changed.
  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance.
  • Code matches the codebase style - Adapter interface, implementation, resolver, and tests follow CLI conventions.
  • Code is formatted with forge fmt - Not applicable; no Solidity files changed.
  • Existing tests pass - Relevant tests pass; full suite not run.
  • New tests are optional - Added adapter and regression tests.
  • All tests pass - forge test not run; no Solidity files changed.
  • Documentation updated - Not applicable; no user-facing command or docs change.
  • Changesets - CLI patch changeset added in a separate commit.

Make sure to follow the contributing guidelines.

Additional Notes

33 targeted tests passed, including 7 Foundry-backed validation tests. Changed files passed ESLint and the CLI bundle build passed. Standalone tsc still reports an existing unrelated error in virtualStorageLayout.ts:325.

@netlify

netlify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 60ba0c8

@changeset-bot

changeset-bot Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 60ba0c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@perfect-abstractions/compose-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0x76agabond
0x76agabond force-pushed the codex/diamond-adapter branch from 47bdd21 to 60ba0c8 Compare October 6, 2026 18:56
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

CLI Coverage

Commit: 60ba0c8

Metric Coverage Covered/Total
Lines 70% 2068/2973
Functions 73% 434/594
Branches 60% 1182/1965

@0x76agabond
0x76agabond merged commit d41b49a into Perfect-Abstractions:main Oct 7, 2026
5 checks passed
@0x76agabond
0x76agabond deleted the codex/diamond-adapter branch October 7, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant