chore(contracts): drop local ERC-8004 registries, use the canonical deployments - #144
Open
JulioMCruz wants to merge 1 commit into
Open
chore(contracts): drop local ERC-8004 registries, use the canonical deployments#144JulioMCruz wants to merge 1 commit into
JulioMCruz wants to merge 1 commit into
Conversation
…eployments Stack does not deploy its own ERC-8004 registries. The app reads and writes the canonical v2 registries at their CREATE2-deterministic addresses (StackApp/lib/utils/config.ts) using hand-maintained ABIs (StackApp/lib/contracts/erc8004/abis.ts). Nothing consumed the Solidity copies: no Foundry script or test referenced them, no broadcast record exists, and deploy-erc8004.ts was a Hardhat script in a directory with no Hardhat config. They had also been uncompilable since 2026-03-08, when Docs/ERC-8004-UPGRADE-PLAN.md rewrote the three interfaces to v2 and left the implementations on the January shape (deleted ValidationRequest struct and ValidationStatus enum, three unimplemented functions, changed return types). Maintaining a private reimplementation of a standard that publishes canonical deployments has no consumer, so remove them instead of finishing the migration. Removed: - src/erc8004/ (3 implementations + 3 interfaces) - scripts/deploy-erc8004.ts Docs updated to match: CLAUDE.md now documents the canonical addresses and the NEXT_PUBLIC_<NETWORK>_*_REGISTRY overrides instead of a deploy flow, and the --skip workarounds in SmartContracts/README.md and Docs/SIWA-ERC8183.md are gone. ERC-8004-UPGRADE-PLAN.md is marked closed. `forge build` and `forge test` now run clean with no --skip flags for the first time; tests 2/2 passing.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #143. Removes the local Solidity copies of the ERC-8004 registries so
forge buildandforge testfinally run clean with no--skipflags.Why remove instead of fix
Nothing consumed them. The app talks to the canonical ERC-8004 v2 registries at their CREATE2-deterministic addresses:
0x8004A169FB4a3325136EB29fA0ceB6D2e539a4320x8004A818BFB912233c491871b3d84c89A494BD9e0x8004BAa17C55a88189AE136b182e5fdA19dE9b630x8004B663056A597Dffe9eCcC1965A193B7388713Those come from
StackApp/lib/utils/config.ts, with ABIs hand-maintained inStackApp/lib/contracts/erc8004/abis.ts(that file's own header explains why:@perkos/contracts-erc8004@1.0.1still describes the pre-v2 contracts).Checked before deleting:
broadcast/record — they were never deployed from this repo.scripts/deploy-erc8004.tsis a Hardhat script andSmartContracts/has no Hardhat config, so it could not run.StackApp/imports nothing fromSmartContracts/.They had not compiled since March.
Docs/ERC-8004-UPGRADE-PLAN.md(2026-03-08, branchupgrade-erc8004-v2, status "In Progress") rewrote the three interfaces to v2 and left every Solidity checkbox unticked. The implementations still referenced the deletedValidationRequeststruct andValidationStatusenum, were missing three interface functions, and had three changed return types. The--skiplists documented inSmartContracts/README.mdandDocs/SIWA-ERC8183.mdexisted to build around exactly this.Finishing that migration would mean maintaining a private reimplementation of a standard that publishes canonical deployments, for no consumer.
Changes
Removed:
SmartContracts/src/erc8004/— 3 implementations + 3 interfacesSmartContracts/scripts/deploy-erc8004.tsDocs realigned:
CLAUDE.md— documents the canonical addresses and theNEXT_PUBLIC_<NETWORK>_{IDENTITY,REPUTATION,VALIDATION}_REGISTRYoverrides; the "Deployment" section no longer tells you to deploy registries that do not exist here.SmartContracts/README.md,Docs/SIWA-ERC8183.md—--skipworkarounds dropped.Docs/ERC-8004-UPGRADE-PLAN.md— marked closed, with the reasoning.The
/api/erc8004/*routes, the ABIs and the TypeScript types are untouched.Verification
Note
NEXT_PUBLIC_<NETWORK>_VALIDATION_REGISTRYstill lets you point at a self-hosted Validation Registry while the official one is not deployed. If we ever want to run one, the right move is deploying the reference implementation from the spec, not reviving these files.