Skip to content

lint red on main: Class-id collision audit flags a test-local CLASS_ID from #11678 #11691

Description

@proggeramlug

lint's "Class-id collision audit" (python3 scripts/class_id_collisions.py) fails on main at 7fa094cb4 with exit code 1:

Class-id MIRROR DRIFT — one name, different values:

  CLASS_ID
      0x00741c77  crates/perry-runtime/src/object/static_shapes_tests.rs:225
      0x7d018001  crates/perry-runtime/src/object/class_registry/state.rs:1360

Cause: #11678 added the test a_class_registered_before_the_pools_answers_the_megamorphic_confirm in object/static_shapes_tests.rs, which declares a local const CLASS_ID: u32 = 0x0074_1c77;. The audit reads it as a mirror of class_registry/state.rs's CLASS_ID with a different value. Fix: rename the test constant (for example TEST_CLASS_ID), or make the audit skip test files.

Found while triaging #11676, where this step was red for this reason alone. It is red on every PR based on current main.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions