Skip to content

regression from #11682: test_gap_fetch_handle_lifecycle, Response subclass body reads back as {} #11700

Description

@proggeramlug

test_gap_fetch_handle_lifecycle has failed on main since #11682 (b67ad0005, "honest handles: EventTarget family are real objects; built-in constructor statics read the constructor").

Bisect on perrymaster (release builds, PERRY_SKIP_BUILD=1 PERRY_NO_AUTO_OPTIMIZE=1 ./run_parity_tests.sh --filter test_gap_fetch_handle_lifecycle, Node 26.5.1, 2 runs each):

It is deterministic. It also fails 4/4 on main 23d563404.

The diff against Node is on line 4:

< request body response body subclass body
> request body response body {}

class RetainedResponse extends Response {}: the subclass instance's body now reads back as {} instead of "subclass body". This looks like #11682's Response/EventTarget honest-handle change losing a subclass wrapper's handle. #11682's own PR CI showed gap-suite (1) and gap-suite (5) red.

Found while triaging #11676. The same failure appears on #11694 and every PR tested against current main.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions